Skip to content

chore: Improve usage of MessageListProvider#35577

Merged
ggazzo merged 18 commits intodevelopfrom
chore/improveMessageList
Apr 28, 2025
Merged

chore: Improve usage of MessageListProvider#35577
ggazzo merged 18 commits intodevelopfrom
chore/improveMessageList

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Mar 20, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

Move some message dependencies up to the provider to decrease usage of useSetting in the message list, as each hook call creates a new meteor computation.

Issue(s)

CORE-1045

Steps to test or reproduce

Further comments

This pull request focuses on improving the usage of the MessageListProvider within the Rocket.Chat codebase. The changes include:

  • Updating the GazzodownText component to use useMessageListShowRealName instead of useSetting for determining the 'useRealName' preference, and adding hooks from @rocket.chat/ui-contexts.
  • Refactoring the MessageHeader component to utilize hooks from the MessageListContext for format functions.
  • Simplifying the useNormalizedMessage hook by consolidating imports from MessageListContext.
  • Modifying the useOembedLayout hook to use useMessageListOembedEnabled for checking oembed settings.
  • Updating the QuoteMessageAction component to use useMessageListAutoTranslate for auto-translate options.
  • Refactoring read receipt settings in useReadReceiptsDetailsAction and other components to use context hooks, enhancing modularity and maintainability.
  • Replacing various useSetting hooks with context-specific hooks across multiple components to improve code organization and consistency.
  • Simplifying the useMessageBody hook by reducing dependencies and parameters, directly using useMessageListAutoTranslate.
  • Enhancing the MessageListProvider by introducing new imports for date and time formatting, restructuring auto-translate and read receipt settings, and refining the context value.

@gabriellsh gabriellsh requested a review from a team as a code owner March 20, 2025 21:39
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 20, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dfe2cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.21%. Comparing base (f9a7f18) to head (dfe2cfc).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35577      +/-   ##
===========================================
+ Coverage    61.19%   61.21%   +0.02%     
===========================================
  Files         3157     3007     -150     
  Lines        74670    71491    -3179     
  Branches     16677    16343     -334     
===========================================
- Hits         45694    43764    -1930     
+ Misses       25877    24757    -1120     
+ Partials      3099     2970     -129
Flag Coverage Δ
e2e 57.86% <90.90%> (-0.01%) ⬇️
unit 75.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35577/

Built to branch gh-pages at 2025-04-28 19:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

ggazzo
ggazzo previously approved these changes Mar 20, 2025
View reviewed changes
@ggazzo ggazzo added this to the 7.6.0 milestone Apr 17, 2025
@kody-ai
Copy link

kody-ai bot commented Apr 17, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 17, 2025
@gabriellsh gabriellsh removed the stat: QA assured Means it has been tested and approved by a company insider label Apr 17, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 17, 2025
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Apr 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 17, 2025
@kody-ai
Copy link

kody-ai bot commented Apr 17, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 17, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 18, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 18, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 19, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 19, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 20, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@kody-ai
Copy link

kody-ai bot commented Apr 21, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@scuciatto scuciatto modified the milestones: 7.6.0, 7.7.0 Apr 22, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 28, 2025
@kody-ai
Copy link

kody-ai bot commented Apr 28, 2025 •
edited
Loading

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody

  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security ✅
Code Style ✅
Kody Rules ✅
Refactoring ✅
Error Handling ✅
Maintainability ✅
Potential Issues ✅
Documentation And Comments ✅
Performance And Optimization ✅
Breaking Changes ❌

Access your configuration settings here.

​

@ggazzo ggazzo merged commit 8e8880f into develop Apr 28, 2025
49 checks passed
@ggazzo ggazzo deleted the chore/improveMessageList branch April 28, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kody-ai kody-ai[bot] kody-ai[bot] left review comments

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Milestone

7.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gabriellsh @ggazzo @scuciatto